Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corpus count methods #46

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix corpus count methods #46

merged 1 commit into from
Oct 23, 2023

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 20, 2023 •
edited
Loading

This change is Reviewable

@ddaspit
Fix corpus count methods
486c52c 
- add support multiple columns in TextFileText.count method
- remove missing_rows_allowed property
- use standard count implementation for StandardParallelTextCorpus
- fixes #23
johnml1135
johnml1135 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit b6a6ea1 into main Oct 23, 2023
13 checks passed
@ddaspit ddaspit deleted the fix-corpus-count branch October 23, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnml1135 johnml1135 johnml1135 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IndexError: Invalid key: 0 is out of bounds for size 0
2 participants
@ddaspit @johnml1135