Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent typeahead results getting lost on form submit #1112

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Oct 9, 2024

Submitting a form triggers a global click, which closes our overlay. For inputs, the overlay only opens on focusin, so it doesn't come back unless the user blurs and focuses again. This ensures that the overlay always comes back.

Submitting a form triggers a global click, which closes our overlay. For inputs, the overlay only opens on focusin, so it doesn't come back unless the user blurs and focuses again. This ensures that the overlay always comes back.
Copy link

github-actions bot commented Oct 9, 2024

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7479ce8. ± Comparison against base commit 4a029e7.

@myieye myieye requested a review from rmunn October 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant