Promote guest users once they verify email #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# Unit Tests66 tests 66 ✅ 5s ⏱️ Results for commit d068c99. |
hahn-kev
approved these changes
Aug 26, 2024
|
Yes, it works; guest users can click the email verification link, and then they are allowed to request project creation. (And once their first project-creation request is approved, they can create more projects without needing approval.) So once guest users have verified an email address, their accounts work just like normal accounts. I did run into #1044 while testing this, but that's unrelated to this PR so I opened a new issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936.
Guest users who add an email address to their account and verify it get promoted from "guest" user status to "regular" user status, so they can now do things like becoming project managers, and so on.
Not much code here, but I believe this is all it takes. Any currently-existing guest users who have verified their email will not be affected by this PR, though, and will need some manual intervention to fix their status.