Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#3525: Goal class has unused field: user #3526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syamjir
Copy link

@syamjir syamjir commented Jan 16, 2025

Hi sillsdev,

I have removed the user-related properties and imports from the Goal class and simplified the constructor and related code.

Please review the changes and provide any feedback.

Thank you!

Resolves #3525


This change is Reviewable

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (0947624) to head (c2d01a9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3526      +/-   ##
==========================================
+ Coverage   74.55%   74.59%   +0.04%     
==========================================
  Files         286      286              
  Lines       11022    11022              
  Branches     1344     1344              
==========================================
+ Hits         8217     8222       +5     
+ Misses       2418     2414       -4     
+ Partials      387      386       -1     
Flag Coverage Δ
backend 83.71% <ø> (+0.09%) ⬆️
frontend 66.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec
Copy link
Collaborator

Thanks for contributing @syamjir.

Please delete the 4 lines completely, rather than leaving extra empty lines in their places.

@imnasnainaec imnasnainaec self-assigned this Jan 16, 2025
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend goal maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goal class has unused field: user
2 participants