[MergeDups] Unify sense-reference info #3490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already exists a type (
MergeTreeReference
) to cover the info extracted from thedraggableId
of both ourDragSense
andSidebarDragSense
. So rather than manually constructing it -- e.g.,-- add a
senseRef: MergeTreeReference
prop for both*DragSense
components. The above then becomes simplydraggableId={JSON.stringify(props.senseRef)}
.This will also allow for easily adding fields to
MergeTreeReference
and have them immediately available when we useThis change is