-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lt 21728c: Parse Prioritizer #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Src/LexText/Interlinear/InterlinVc.cs
line 2539 at r1 (raw file):
// recreate the guess services, so they will use the latest FDO data. GuessServices.ClearGuessData(); // clear the Decorator cache for the guesses, so it won't have any stale data.
remove decorator from comment
Code quote:
Decorator
I think something like the following would be a better: |
also adjust this exception. |
and all the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
I changed FieldWorks so that it could guess occurrences based on the previous word. I also made InterlinViewDataCache be a guess cache instead of a decorator.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)