Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lt 21728c: Parse Prioritizer #97

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Lt 21728c: Parse Prioritizer #97

merged 3 commits into from
Jul 8, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Jul 3, 2024

I changed FieldWorks so that it could guess occurrences based on the previous word. I also made InterlinViewDataCache be a guess cache instead of a decorator.


This change is Reviewable

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)


Src/LexText/Interlinear/InterlinVc.cs line 2539 at r1 (raw file):

			// recreate the guess services, so they will use the latest FDO data.
			GuessServices.ClearGuessData();
			// clear the Decorator cache for the guesses, so it won't have any stale data.

remove decorator from comment

Code quote:

Decorator 

@jasonleenaylor
Copy link
Contributor

Src/LexText/Interlinear/InterlinViewDataCache.cs line 42 at r1 (raw file):

			{
				default:
					throw new ArgumentException("tag", tag.ToString());

I think something like the following would be a better:
throw new ArgumentException(string.format("Unhandled property: {tag}", nameOf(tag));

@jasonleenaylor
Copy link
Contributor

Src/LexText/Interlinear/InterlinViewDataCache.cs line 53 at r1 (raw file):

			{
				default:
					throw new ArgumentException("tag", tag.ToString());

also adjust this exception.

@jasonleenaylor
Copy link
Contributor

Src/LexText/Interlinear/InterlinViewDataCache.cs line 69 at r1 (raw file):

			{
				default:
					throw new ArgumentException("tag", tag.ToString());

and all the rest.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor enabled auto-merge (rebase) July 8, 2024 17:16
@jasonleenaylor jasonleenaylor merged commit 548fc4b into release/9.1 Jul 8, 2024
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21728c branch July 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants