Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-21787: Fix hyperlink to another project #91

Closed
wants to merge 5 commits into from

Conversation

JakeOliver28
Copy link
Contributor

@JakeOliver28 JakeOliver28 commented Jun 25, 2024

Fix hyperlink to another project if the target
object exists in the source project.


This change is Reviewable

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) June 25, 2024 16:08
@jasonleenaylor
Copy link
Contributor

Src/xWorks/LinkListener.cs line 505 at r2 (raw file):

				// Return false if the link is to a different database
				var databases = m_lnkActive.PropertyTableEntries.Where(p => p.name == "database");
				if (databases.Any() && databases.First().name != cache.LangProject.ShortName)

This could probably be shortened with a .FirstOrDefault(),
I see that SameDatabase doesn't work for a FwLinkArgs, this is probably as good as we can do without a bigger refactor.

Copy link

github-actions bot commented Jun 28, 2024

⚠️ Commit Message Format Issues ⚠️
commit fe28e1d574:
1: T1 Title exceeds max length (73>72): "Shorten conditional statement checking hyperlink for a different database"

auto-merge was automatically disabled June 28, 2024 15:12

Pull request was closed

@JakeOliver28 JakeOliver28 deleted the LT-21787-2nd branch July 22, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants