Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21810: Yellow Crash occurs while parsing with Default Parser(XAmple) #86

Merged
merged 3 commits into from
Jun 21, 2024
+14 −9
Merged

Fix LT-21810: Yellow Crash occurs while parsing with Default Parser(XAmple) #86

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
743f406
Fix LT-21810
jtmaxwell3 Jun 19, 2024
ac1e42d
Suppress parsing of lowercase words that don't exist
jtmaxwell3 Jun 19, 2024
1e84bd7
Merge branch 'release/9.1' into LT-21810
jasonleenaylor Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
Fix LT-21810
@jtmaxwell3
jtmaxwell3 committed Jun 19, 2024
commit 743f4064bab0d2b096c1c16e144782f614cd3de8
6 changes: 4 additions & 2 deletions Src/LexText/ParserCore/ParserWorker.cs
View file
Original file line number Diff line number Diff line change
@@ -178,8 +178,10 @@ public bool UpdateWordform(IWfiWordform wordform, ParserPriority priority)
if (lcResult.Analyses.Count > 0 && lcResult.ErrorMessage == null)
{
var text = TsStringUtils.MakeString(sLower, form.get_WritingSystem(0));
var lcWordform = WfiWordformServices.FindOrCreateWordform(m_cache, text);
m_parseFiler.ProcessParse(lcWordform, priority, lcResult);
IWfiWordform lcWordform;
// We cannot use WfiWordformServices.FindOrCreateWordform because of props change (LT-21810).
if (m_cache.ServiceLocator.GetInstance<IWfiWordformRepository>().TryGetObject(text, out lcWordform))
m_parseFiler.ProcessParse(lcWordform, priority, lcResult);
m_parseFiler.ProcessParse(wordform, priority, result);
return true;
}

Unchanged files with check annotations Beta

View file
Lib/src/graphite2/src/Collider.cpp
#if !defined GRAPHITE2_NTRACING
if (dbgout)
dbgout->setenv(1, reinterpret_cast<void *>(j));

Check warning on line 512 in Lib/src/graphite2/src/Collider.cpp

GitHub Actions / Build Debug and run Tests 

'reinterpret_cast': conversion from 'int' to 'void *' of greater size
#endif
if (omin > otmax)
_ranges[i].weightedAxis(i, vmin - _margin, vmax + _margin, 0, 0, 0, 0, 0,
View file
Lib/src/graphite2/src/Silf.cpp
<< json::close;
}
#endif
if (seg->currdir() != m_dir)

Check warning on line 397 in Lib/src/graphite2/src/Silf.cpp

GitHub Actions / Build Debug and run Tests 

'!=': unsafe mix of type 'bool' and type 'const graphite2::uint8' in operation
seg->reverseSlots();
if (m_aMirror && (seg->dir() & 3) == 3)
seg->doMirror(m_aMirror);
View file
Lib/src/unit++/GlobalSetup.cc
* It is called from main(). Programmers can supply their own version to
* replace this null version.
*/
void GlobalSetup(bool verbose)

Check warning on line 12 in Lib/src/unit++/GlobalSetup.cc

GitHub Actions / Build Debug and run Tests 

'verbose': unreferenced formal parameter
{
}