Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LT-21786: Show variant info for analysis chooser #72

Merged
merged 4 commits into from
Jun 3, 2024
Merged

LT-21786: Show variant info for analysis chooser #72

merged 4 commits into from
Jun 3, 2024

Conversation

JakeOliver28
Copy link
Contributor

@JakeOliver28 JakeOliver28 commented May 30, 2024 •
edited by jasonleenaylor
Loading

This change is Reviewable

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) May 30, 2024 21:17
@jasonleenaylor
Copy link
Contributor

Src/LexText/Interlinear/ChooseAnalysisHandler.cs line 378 at r1 (raw file):

			ITsStrBldr tsb = TsStringUtils.MakeStrBldr();
			ISilDataAccess sda = fdoCache.MainCacheAccessor;
			ILexEntry entry = null;

I don't think this change was necessary.

jasonleenaylor
jasonleenaylor reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @JakeOliver28)

JakeOliver28
JakeOliver28 commented May 31, 2024
View reviewed changes
Copy link
Contributor Author

@JakeOliver28 JakeOliver28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)

Src/LexText/Interlinear/ChooseAnalysisHandler.cs line 378 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I don't think this change was necessary.

Got rid of the unnecessary changes here.

jasonleenaylor
jasonleenaylor approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JakeOliver28)

@JakeOliver28 JakeOliver28 merged commit 98bb48c into release/9.1 Jun 3, 2024
5 checks passed
@JakeOliver28 JakeOliver28 deleted the LT-21786-Second-Branch branch June 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeOliver28 @jasonleenaylor