Fix LT-21797: Missing highlights in Analyze tab

[jtmaxwell3]

Implementing LT-21777 (Mark guessed analyses in InterlinearExport) broke the highlighting in the interlinear display because the extra AddProp threw the display code off. I changed the code to mark the guessed analysis using set_StringProp instead, which required me to implement set_StringProp in CollectorEnv.

---

This change is 

[mark-sil]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3)

---

Src/Common/RootSite/CollectorEnv.cs line 96 at r1 (raw file):

			public int m_ihvo;
			/// <summary>String properties of the current item</summary>
			public Dictionary<int, string> m_stringProps;

Are you intending to make additional changes that will take advantage of the Dictionaries that are declared here and at line 342? If not, then it is not clear to me why we are using Dictionaries. Can you accomplish the same thing with a tagAnalysisStatus bool or enum?

Code quote:

Dictionary<int, string> m_stringProps;

[jtmaxwell3]

CollectorEnv is used by multiple clients. None of them currently make use of set_StringProp, but I figured that as long as I was going to implement that function, I should implement it for the general case and not just for InterlinearExplorer's current need. In the general case, set_StringProp could be called multiple times before the next AddObj, so it seemed appropriate to use a Dictionary for the properties.

[mark-sil]

I didn't think other clients were calling into Fieldworks code. Do you mean multiple derived classes?

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3)

[jtmaxwell3]

I'm not sure what you mean by multiple derived classes. I meant that CollectorEnv is used by ConfiguredExport, ItemsCollectorEnv, FindCollectorEnv, and DiscourseExporter in addition to InterlinearExporter. The original comment on set_StringProp said "Nothing to do here. None of our collectors cares about string properties (yet)", so I wanted to future-proof my change.

[mark-sil]

Yes, those look like derived classes. I tend toward simplifying until needed but your reasoning makes sense. LGTM.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3)

[mark-sil]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)