Word Export: Code cleanup #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no logic changes in this PR, just cleanup. - Changed the name of some methods. - Changed eachInAParagraph to eachOnANewLine. For Word Export a Paragraph is a class and carries a specific meaning. We are not putting the data in a separate OpenXml.Wordprocessing.Paragraph, just starting a new line. So I changed the names to try and reduce confusion. Change-Id: I94eca41b7fa173b04990877429ab607736aa7774
jasonleenaylor
approved these changes
May 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no logic changes in this PR, just cleanup.
Change-Id: I94eca41b7fa173b04990877429ab607736aa7774
This change is