Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lt 21777 Mark guessed analyses #40

Merged
merged 6 commits into from
May 3, 2024
Merged

Lt 21777 Mark guessed analyses #40

merged 6 commits into from
May 3, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented May 2, 2024 •
edited by jasonleenaylor
Loading

Indicate guessed analyses in flextext output

  • Change InterlinVc.DisplayMorphemes to let the exporter know that an analysis is guessed
  • Change InterlinearExporter to add analysisStatus="guess" to guessed analyses

This change is Reviewable

jasonleenaylor
jasonleenaylor approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit 812f532 into release/9.1 May 3, 2024
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21777 branch May 3, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtmaxwell3 @jasonleenaylor