LT-21751: Implement writing system styles #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When starting a run, add a writing system style if the run has a WS specified. - If the run should have an additional style associated with it, replace the writing system style with a link to the writing system specific version of the additional style. - Use RunFonts object instead of Font object to specify fonts for character styles in word. Change-Id: Ib079c9941ed194e6301ea81901ca937c39bbd428
mark-sil
approved these changes
May 2, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aror92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a run, add a writing system style if the run has a WS specified.
If the run should have an additional style associated with it, replace the writing system style with a link to the writing system specific version of the additional style.
Use RunFonts object instead of Font object to specify fonts for character styles in word.
This change is