Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-21761: Fix indenting for the first line after a Table #37

Merged
merged 4 commits into from
May 2, 2024

Conversation

mark-sil
Copy link
Contributor

@mark-sil mark-sil commented May 1, 2024

The first line of an entry typically uses FirstLineIndent to indented to the left. When we have multiple paragraphs for an entry (because the entry contains Tables or Pictures) then we do not want the line following the Table or Picture to also be indented to the left. We now create a ‘continuation’ style for paragraphs following a table or picture. It is the same as the original style except it does not use FirstLineIndent.

Change-Id: I67e282e4a02f1ff9145dfb198c4432823d156413


This change is Reviewable

The first line of an entry typically uses FirstLineIndent to
indented to the left. When we have multiple paragraphs for an
entry (because the entry contains Tables or Pictures)
then we do not want the line following the Table or Picture to
also be indented to the left. We now create a ‘continuation’
style for paragraphs following a table or picture.  It is the
same as the original style except it does not use
FirstLineIndent.

Change-Id: I67e282e4a02f1ff9145dfb198c4432823d156413
@jasonleenaylor
Copy link
Contributor

Src/xWorks/LcmWordGenerator.cs line 1110 at r1 (raw file):

			// Each entry starts a new paragraph, and any entry data added will usually be added within the same paragraph.
			// The paragraph will end whenever a data type that cannot be in a paragraph is encounter (Tables or Pictures).
			// A new 'continuation' paragraph will be started after the Table ot Picture if there is other data that still

sp.

Change-Id: I819bc38e8e21eb2fc6b06f2c8c910e1428d710d5
Copy link
Contributor Author

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jasonleenaylor)


Src/xWorks/LcmWordGenerator.cs line 1110 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

sp.

Fixed

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

@mark-sil mark-sil merged commit 29defce into release/9.1 May 2, 2024
5 checks passed
@mark-sil mark-sil deleted the LT-21761b branch May 2, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants