Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lt 21728 #36

Merged
merged 4 commits into from
May 1, 2024
Merged

Lt 21728 #36

merged 4 commits into from
May 1, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented May 1, 2024

  • Incorporate liblcm 11.0.0-beta0089 (improves GetBestGuess)
  • Add calls to GetSortedAnalysisGuesses and GetSortedGlossGuesses

This change is Reviewable

Copy link

github-actions bot commented May 1, 2024

⚠️ Commit Message Format Issues ⚠️

commit a42c30ca12:
1: T3 Title has trailing punctuation (.): "Change to liblcm beta0089."

@jasonleenaylor
Copy link
Contributor

x64/Debug/System.ValueTuple.dll line 0 at r1 (raw file):
This file should not be included in the commit.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit bea232f into release/9.1 May 1, 2024
4 of 5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21728 branch May 1, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants