Add BasedOn style property and fix duplicate styles #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add based on property when generating styles from LCM stylesheet that have based on specified in FLEx. - Edit styleDictionary to store individual styles instead of groups of styles. - Revise AddStyles so it adds each style one time only, using the stylenames instead of css classes as the dictionary keys. NOTE: In the Word export, the style dictionary should save each style individually rather than a collection of styles associated with a given css class. Otherwise, any given style may be added to the styles xml multiple times, once for each css class using that style. Remaining task: - Homograph-Number style is still being duplicated. It is handled in a different function and requires its own fix. Change-Id: I9530c894fdae8251ab4211f1c7529fa63586b446
jasonleenaylor
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aror92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add based on property when generating styles from LCM stylesheet that have based on specified in FLEx.
Edit styleDictionary to store individual styles instead of groups of styles.
Revise AddStyles so it adds each style one time only, using the stylenames instead of css classes as the dictionary keys.
NOTE: In the Word export, the style dictionary should save each style individually rather than a collection of styles associated with a given css class.
Otherwise, any given style may be added to the styles xml multiple times, once for each css class using that style.
Remaining task:
Change-Id: I9530c894fdae8251ab4211f1c7529fa63586b446
This change is