Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-20853: Fix FocusBox word bundle elements' order #31

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

JakeOliver28
Copy link
Contributor

@JakeOliver28 JakeOliver28 commented Apr 25, 2024

This change is Reviewable

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) April 25, 2024 21:02
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JakeOliver28)


Src/LexText/Interlinear/InterlinDocForAnalysis.cs line 1842 at r1 (raw file):

				if ((ExistingFocusBox == null && ForEditing) || hasRightToLeftChanged)
				{
					CreateFocusBox();

This is creating a UserControl which is a Disposable object, so if you are going to be calling it when there is an existing one the old one needs to be destroyed. This could either be done in the CreateFocusBox implementations or in the ExistingFocusBox set method..

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JakeOliver28)

@jasonleenaylor jasonleenaylor disabled auto-merge April 26, 2024 22:42
@jasonleenaylor jasonleenaylor enabled auto-merge (squash) April 26, 2024 22:44
@jasonleenaylor jasonleenaylor merged commit 3fdca2b into release/9.1 Apr 26, 2024
4 of 5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-20853 branch April 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants