LT-21761 & LT-21674: Handle Before, Between, After and more #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle Before, Between, After, and DisplayInSeparateParagraphs. Remaining tasks: - Tables still need indenting. - The first line after a table is shifted to the left. A new ‘continuation’ style is needed when we start a new paragraph. - Before, Between, and After might need to use a different style. Change-Id: I784a31d32b4c1b920141db90eb10d76d2f502ea4
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Src/xWorks/LcmWordGenerator.cs line 668 at r1 (raw file):
{ displayEachInAParagraph = true; }
I think I'd go with:
var displayEachInAParagraph = config != null &&
config.DictionaryNodeOptions is IParaOption &&
((IParaOption)(config.DictionaryNodeOptions)).DisplayEachInAParagraph
Handle Before, Between, After, and DisplayInSeparateParagraphs. Remaining tasks: - Tables still need indenting. - The first line after a table is shifted to the left. A new ‘continuation’ style is needed when we start a new paragraph. - Before, Between, and After might need to use a different style. Change-Id: I5a19055412025faf3b7c1f1cc67f4285629758b0
mark-sil
commented
Apr 25, 2024
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @jasonleenaylor)
Src/xWorks/LcmWordGenerator.cs line 668 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
I think I'd go with:
var displayEachInAParagraph = config != null && config.DictionaryNodeOptions is IParaOption && ((IParaOption)(config.DictionaryNodeOptions)).DisplayEachInAParagraph
Done
jasonleenaylor
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Before, Between, After, and DisplayInSeparateParagraphs. Remaining tasks:
Change-Id: I784a31d32b4c1b920141db90eb10d76d2f502ea4
This change is