Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #77

Merged
merged 15 commits into from
Oct 2, 2024
Merged

Release 4.0.0 #77

merged 15 commits into from
Oct 2, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 20, 2024

Added

Changed

  • CallApi returns an error instead of panic

Removed

  • Deleted commented out code
  • Removed TFVars struct as it was a strict subset of the Vars struct.
  • Removed deprecated --dry-run-mode flag

jason-jackson and others added 15 commits April 24, 2024 17:53
@jason-jackson
remove dry-run-mode flag
2c40ff5
@jason-jackson
have callApi return an error instead of panic
6e02ae9
@jason-jackson
merge tfvars struct into vars struct
5cf5f17
@jason-jackson
Merge pull request #73 from silinternational/feature/remove-dry-run
d210a73 
remove dry-run-mode flag
@jason-jackson
Merge pull request #75 from silinternational/feature/merge-vars-tfvars
90f5cc7 
merge tfvars struct into vars struct
@jason-jackson
Merge pull request #74 from silinternational/feature/call-api-return-…
9f350ed 
…error

have callApi return an error instead of panic
@briskt
get credentials from user's terraform config directory
e1fae67
@briskt
refactor readTerraformCredentials
59f1194
@briskt
update goreleaser action
f5eb692
@briskt
update test workflow
43195bf
@briskt
update goreleaser-action to v5
060b9c4
@briskt
update setup-go and checkout actions
fd15597
@briskt
lock goreleaser to v1
b8a797b
@briskt
correct typo in credentialsPath
da7292a
@briskt
Merge pull request #76 from silinternational/feature/terraform-creds
1c80ff8 
get credentials from user's terraform config directory
@briskt briskt requested review from a team, jason-jackson and hobbitronics and removed request for a team September 20, 2024 07:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics approved these changes Sep 24, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements

@briskt briskt merged commit 03cbff7 into main Oct 2, 2024
3 checks passed
@briskt briskt deleted the release/v4.0.0 branch October 2, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson was automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use API token in ~/.terraformrc
3 participants
@briskt @hobbitronics @jason-jackson