Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rather than setting the default_version to 1, use the latest version #88

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Rather than setting the default_version to 1, use the latest version #88

merged 1 commit into from
Aug 29, 2023

Conversation

forevermatt
Copy link
Contributor

Fixed

  • Rather than setting the default_version to 1, use the latest version
    • I have not yet tested this, but the documentation is here.

@forevermatt forevermatt requested a review from a team August 23, 2023 19:38
dalenewby
dalenewby reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@dalenewby dalenewby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What caused you to make this change? The documentation is not helpful in explaining the value for either default_version or update_default_version and both of them are optional (so why did we specify either one of them?).

@forevermatt forevermatt merged commit 62281de into develop Aug 29, 2023
2 checks passed
@forevermatt forevermatt deleted the feature/fix-asg-launch-template-default-version branch August 29, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalenewby dalenewby dalenewby left review comments

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forevermatt @briskt @dalenewby