Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to vite and remove @vue/cli-service and other related packages #180

Merged
merged 28 commits into from
Oct 1, 2024
Merged

switch to vite and remove @vue/cli-service and other related packages #180

merged 28 commits into from
Oct 1, 2024

Conversation

hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Sep 27, 2024 •
edited
Loading

IDP-1199, IDP-1240

used this repo and the guide

Added

  • add vite "bundler"

Changed

  • changed env's from VUE_APP_, TO VITE_ (will need to rename these in cloudflare skinny repos like this PR)

Removed

  • @vue/cli-service and other related packages

Security

  • Fixed multiple cve's by removing packages

Feature branch checklist

  • Documentation (README, etc.)
  • update version in package.json
  • Run make depsupdate

@hobbitronics hobbitronics requested a review from a team as a code owner September 27, 2024 05:18
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team September 27, 2024 05:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

forevermatt
forevermatt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection from me. I didn't try it out myself, but it looks good. If this works, go for it. Thanks for tackling this! 👍

@hobbitronics
Copy link
Contributor Author

No objection from me. I didn't try it out myself, but it looks good. If this works, go for it. Thanks for tackling this! 👍

When you get a chance to try, you'll notice changes appear instantly and starting up is much faster.

@hobbitronics hobbitronics merged commit 1b71fe6 into develop Oct 1, 2024
2 checks passed
@hobbitronics hobbitronics deleted the feature/use-vite branch October 1, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@briskt briskt Awaiting requested review from briskt briskt is a code owner automatically assigned from silinternational/js-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/js-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/js-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobbitronics @forevermatt