Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idp 781 update last login after mfa #373

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Idp 781 update last login after mfa #373

merged 6 commits into from
Sep 19, 2024

Conversation

hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Sep 19, 2024 •
edited by briskt
Loading

IDP-781

Added

  • user/{employee_id}/update-last-login endpoint

Feature PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@hobbitronics hobbitronics requested a review from a team as a code owner September 19, 2024 07:56
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team September 19, 2024 07:56
briskt
briskt approved these changes Sep 19, 2024
View reviewed changes
api.raml Outdated Show resolved Hide resolved
application/features/user.feature Outdated Show resolved Hide resolved
application/features/user.feature Outdated Show resolved Hide resolved
@briskt
Copy link
Contributor

briskt commented Sep 19, 2024

Great work!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hobbitronics
Copy link
Contributor Author

Great work!

Thanks for your help, especially on those tests!

@hobbitronics hobbitronics merged commit 692e2dd into develop Sep 19, 2024
3 checks passed
@hobbitronics hobbitronics deleted the idp-781-update-last_login-after-mfa branch September 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobbitronics @briskt