Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.8.2 -- added User-Agent header to MFA API client #370

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Release 6.8.2 -- added User-Agent header to MFA API client #370

merged 5 commits into from
Sep 18, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 17, 2024

Added

  • Added a CODEOWNERS file
  • Added GitHub Actions config to add semantic version tags to Docker image (e.g. 1.2 for tag 1.2.3)
  • Added a User-Agent header to MFA API client

Fixed

  • Filled in some gaps in api.raml

Feature PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@briskt briskt requested review from a team, forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team September 17, 2024 09:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@briskt briskt merged commit fbe83f4 into main Sep 18, 2024
3 checks passed
@briskt briskt deleted the develop branch September 18, 2024 02:08
@forevermatt forevermatt restored the develop branch September 18, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics