Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDP-1176] Add groups_external field, part 2 (cleanup) #354

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[IDP-1176] Add groups_external field, part 2 (cleanup) #354

merged 1 commit into from
Aug 20, 2024

Conversation

forevermatt
Copy link
Contributor

IDP-1176 Add groups_external field to ID Broker's database

WAITING FOR

Fixed

  • Extract User->getMemberList() method
    • The only change to the extracted code was replacing $model with $this in a few places.
    • This helps reduce the complexity of the User->fields() method, which was getting overly complicated.

Feature PR Checklist

  • Documentation (README, local.env.dist, etc.)
  • Unit tests created or updated
  • Run make composershow
  • Run make psr2

@forevermatt
Extract User->getMemberList() method
d677e2e 
This helps reduce the complexity of the `User->fields()` method, which
was getting overly complicated.
@forevermatt forevermatt requested a review from a team August 19, 2024 19:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from feature/idp-1176-add-groups-external-field to develop August 20, 2024 14:41
@forevermatt forevermatt merged commit 9ad7b66 into develop Aug 20, 2024
3 checks passed
@forevermatt forevermatt deleted the feature/idp-1176-add-groups-external-field-part-2 branch August 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset mtompset approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forevermatt @briskt @mtompset