Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker images for lg / lgproxy #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmarsay
Copy link
Contributor

@gmarsay gmarsay commented Jun 15, 2020

We are currently using lg and lgproxy in Docker containers. Would you like to include this branch in the repositories?

The installation of a construction chain is described here: https://medium.com/better-programming/build-your-docker-images-automatically-when-you-push-on-github-18e80ece76af

@zorun
Copy link
Collaborator

zorun commented Jun 16, 2020

Yes, this is interesting.

Can you move the files to a subdirectory and add a small README, like it is done with init/?

@zorun
Copy link
Collaborator

zorun commented Jun 16, 2020

That is, I'm assuming that people might use these Dockerfile on their own.

Do you mean that we could publish "official" bird-lg images? If this requires Dockerfiles to be at the root of the project, then it's fine to keep them here.

@zorun zorun mentioned this pull request Jun 16, 2020
@zorun
Copy link
Collaborator

zorun commented Jun 16, 2020

I wonder how you handle configuration?

Since providing Docker images would need lots of discussion, I have opened #76 to track this.

We can already merge this to provide a reference (preferably in a subdirectory as explained above)

@zorun
Copy link
Collaborator

zorun commented Jun 6, 2021

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants