-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch up autodoc code blocks #2180
Conversation
…nual" This reverts commit 9f760d8.
-- a \raw environment. For this purpose we don't care about and don't want to bother with | ||
-- making sure the leading and trailing whitespace is minimized in the SIL source, so | ||
-- we trim it off here. | ||
content = SU.ast.trimSubContent(content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change sound right to you @Omikhleia? The whitespace being passed in the \raw
blocks now being (legitimately) treated as actual lines seems to be the main problem that blew up the manual. My previous fix was obviously wrong, this seems right now. I did tweak the alignment of the rule just a little bit and used raise instead of manually pushing VGlue because sorting out when to add spacing or not was much easier that way. Hence the final test expectations did change just a small shim. I also did not place \novbreak
before and after the cod blocks as that seems to introduce yet another problem we'd have to cancel out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can say viewing the code (not tested yet), it seems ok.
What is the problem your are having with novbreak, if I may ask? I've some regression (it seems) on them too, though I've not been able yet to track its origin. (Something changed in paragraphing, possibly unrelated however.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside the verbatim (or autodoc:codeblock which does the same thing with line handling, if you do not explicitly leave hmode before adding the novbreaks then it flips you over to vmode itself and you end up with a double break. I didn't work on an MWE.
Closes #2168