Add fileExtension + mimetypes check on JS side #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 100% 100%
Complexity 13 13
=======================================
Files 7 7
Lines 33 33
=======================================
Hits 33 33Continue to review full report at Codecov.
|
| @@ -39,6 +39,8 @@ | |||
| $('div.{{ form.vars.id }}').dmUploader({ | |||
| url: '{{ form.vars.action }}', | |||
| maxFileSize: 30000000000, | |||
| extFilter: {{ provider.allowedExtensions|json_encode|raw }}, | |||
There was a problem hiding this comment.
Should we add a default here, too if not set?
There was a problem hiding this comment.
I tried and it seems not necessary.
There was a problem hiding this comment.
By the way we could get errors when the provider injected is not an instance of FileProvider. I'll add a check whether methods are defined.
|
Please note that the composer.json file needs to be updated before you tag a new version. 3.15 of the mediabundle is required. |
|
i will release first if the issue is fully done. |
This is a first fix of fileExtension checking issue raised in #16
Before merging this one, we need to get the sonata-project/SonataMediaBundle#1451 merged first.