Refactor feature testing for spec tests #6737
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
FeatureName
usage.Additional Details
Removed previously hard coded
EIP7594_*
constants, and specify the feature tests at the handler level, this is more flexible, and allows for multiple features to be developed in parallel. For example:When running a test for a feature, tests used to be written this way:
This is quite verbose and may lead to inconsistency between tests. This has been modified to specify the fork at the
FeatureName
level, so the fork used is only specified once in thefeature_name.fork_name()
function.