Modularize validator store #6705
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dknopik
force-pushed
the
modularize-validator-store
branch
from
8d8476f to
026cdbe
Compare
…rom-validator-client
dknopik
force-pushed
the
modularize-validator-store
branch
from
1e926e0 to
3c253b4
Compare
Co-authored-by: ThreeHrSleep <[email protected]>
Co-authored-by: ThreeHrSleep <[email protected]>
dknopik
force-pushed
the
modularize-validator-store
branch
from
3c253b4 to
838eed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for modularizing the validator store so that we can reuse the validator services in Anchor. It is very work in progress. :)
Proposed Changes
ValidatorStorewith all functions used by thevalidator_servicesvalidator_servicesgeneric onS: ValidatorStoreLighthouseValidatorStore, which has identical functionality to the oldValidatorStoreenvironment) fromvalidator_servicesandbeacon_node_fallbackin order to be able to cleanly use them in AnchorAdditional Info
This is dependent on the tracing integration changes (#6339) - for development, I pulled in some changes manually in the required places. This breaks Lighthouse, so I have not yet tried running Lighthouse with these changes.