New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for EIP 6110 #6704

Open

bshastry wants to merge 1 commit into sigp:unstable from bshastry:tests-eip6110

bshastry commented Dec 16, 2024

Issue Addressed

Implements test coverage for EIP-6110 (Electra) deposit mechanism transition.

Proposed Changes

Added test test_deposit_mechanism_transition that verifies:
1. Pre-Electra deposits work correctly (lines 1164-1177)
2. Initial deposit request state is correct (lines 1187-1190)
3. New deposit request mechanism works post-Electra (lines 1193-1202)
4. Deposit request index is tracked properly (lines 1204-1208)
5. Old deposit mechanism is properly disabled (lines 1210-1218)

Additional Info

Key aspects tested:

Proper initialization of deposit_requests_start_index during fork upgrade
Correct handling of deposit count validation pre/post transition
Graceful rejection of old-style deposits after transition

Future considerations:

May want to add tests for edge cases around the transition boundary
Could extend to test pending balance deposits processing


          Add tests for EIP 6110

a1c944f

michaelsproul added the electra label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

electra