Add Fulu boilerplate #6695
Add Fulu boilerplate #6695
Conversation
| @@ -5322,7 +5322,8 @@ impl<T: BeaconChainTypes> BeaconChain<T> { | |||
| BeaconState::Bellatrix(_) | |||
| | BeaconState::Capella(_) | |||
| | BeaconState::Deneb(_) | |||
| | BeaconState::Electra(_) => { | |||
| | BeaconState::Electra(_) | |||
| | BeaconState::Fulu(_) => { | |||
There was a problem hiding this comment.
Can we do fork.after_bellatrix here? the argument of using a match to force us to think about the fork is broken here, because we don't know what EIPs will exist in the fork and if we need a new handler. So now we are getting the worst of both worlds. a 1980 lines boilerplate PR and no guarantees or correctness
| } | ||
| SignedBeaconBlock::Deneb(_) | ||
| | SignedBeaconBlock::Electra(_) | ||
| | SignedBeaconBlock::Fulu(_) => (signed_block, block_response.blob_items), |
There was a problem hiding this comment.
This can also be .after_deneb()
| | ForkName::Altair | ||
| | ForkName::Deneb | ||
| | ForkName::Electra | ||
| | ForkName::Fulu => Err(Error::UnsupportedForkVariant(format!( |
There was a problem hiding this comment.
This should be a default case, we will never use v2 again
| let params = json!([JsonPayloadIdRequest::from(payload_id)]); | ||
|
|
||
| match fork_name { | ||
| ForkName::Fulu => { |
There was a problem hiding this comment.
can we use match(fulu) or after_fulu?
| @@ -1,14 +1,14 @@ | |||
| # Mainnet config | |||
|
|
|||
| # Extends the mainnet preset | |||
| PRESET_BASE: 'mainnet' | |||
| PRESET_BASE: "mainnet" | |||
There was a problem hiding this comment.
We should maintain same format as upstream file https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml
Proposed Changes
Adds Fulu fork boilerplate.
Additional Info
Certain types will likely need a new Fulu variant but have been omitted for simplicity (e.g Light client types).
This also makes no attempt to unify Fulu with PeerDAS. This will need to be a separate PR.