Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new features to mergify config #6597

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Conversation

jxs
Copy link
Member

@jxs jxs commented Nov 20, 2024

Issue Addressed

While addressing an issue on the rust-libp2p mergify.yml config file, finally had time to read its doc and suggest some nice things it has there to the lighthouse repo:

  • automatically notify PR authors when their PR has conflicts with the target PR branch
  • add the ability to PR's to the mergify queue by adding the add-to-queue label instead of having to reply to the PR with "@Mergifyio queue"
  • add the ability to merge trivial PRs without other approvals by adding the trivial label

Notes

  • the lighthouse team doesn't exist yet, we can create it or use the sigp team which has all its members
  • took the opportunity to also change the merged commit message by instead of having the commits having the PR description sections, tell me wdyt @jimmygchen, @michaelsproul

@jxs jxs requested a review from jimmygchen November 20, 2024 16:12
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@jxs jxs requested a review from michaelsproul November 20, 2024 16:12
@chong-he chong-he added ready-for-review The code is ready for review infra-ci labels Nov 21, 2024
@chong-he
Copy link
Member

May need to change the target branch to unstable?

@jxs
Copy link
Member Author

jxs commented Dec 4, 2024

May need to change the target branch to unstable?

Hi Ck, since this affects CI needs to be merged against stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants