Allow custody by root requests to have no peers #6417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
ready-for-review
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 012e7e7 |
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Currently, a post-PeerDAS lookup will immediately fail if we have no custody peers on a necessary column. This should be a common scenario if the peer manager can't find a well-distributed set of peers to cover all columns. Instantly failing the lookup is sub-optimal as the block will be added to fail chains and delays recovery.
Proposed Changes
This PR allows lookups so sit in a "stalled" state where one or more individual column requests are sitting idle unable to progress. But: