Refactor data column reconstruction and avoid blocking processing #6403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code and avoids having to pass `DataColumnsToPublish` around and blocking other processing.
jimmygchen
added
ready-for-review
dapplion
reviewed
Sep 18, 2024
| @@ -3166,15 +3192,13 @@ impl<T: BeaconChainTypes> BeaconChain<T> { | |||
|
|
|||
| /// Remove any block components from the *processing cache* if we no longer require them. If the | |||
| /// block was imported full or erred, we no longer require them. | |||
| fn remove_notified_custody_columns<P>( | |||
| fn remove_notified_custody_columns( | |||
There was a problem hiding this comment.
If the return value does not have P, we can probably remove the function in favor of remove_notified
There was a problem hiding this comment.
Nice, didn't realize they're identical!
| "result" => "imported block and custody columns", | ||
| "block_hash" => %hash, | ||
| ); | ||
| self.chain.recompute_head_at_current_slot().await; |
There was a problem hiding this comment.
Should we compute the head before publishing the columns? I don't have metrics but scheduling the columns for publishing should not block this thread for too long, and it's timing sensitive for the network to do so as soon as possible.
There was a problem hiding this comment.
Good catch! Recompute head should definitely happen after publish - publish is non blocking anyway.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Continuation of #5990.
I've taken the changes from #5990 with some cleanups. This should simplify the code a bit and reduce supernode bandwidth and performance (reconstruction no longer blocks DA processing for the block).
Proposed Changes
overflow_lru_cache, this simplifies the code and avoids having to passDataColumnsToPublisharound.