Generalize sync ActiveRequests #6398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
ready-for-review
dapplion
force-pushed
the
sync-active-request-generalize
branch
from
2e502a9
to
043d52b
Compare
dapplion
commented
Sep 17, 2024
| @@ -42,11 +37,19 @@ pub enum SyncRequestId { | |||
| /// Request searching for a set of blobs given a hash. | |||
| SingleBlob { id: SingleLookupReqId }, | |||
| /// Request searching for a set of data columns given a hash and list of column indices. | |||
| DataColumnsByRoot(DataColumnsByRootRequestId, DataColumnsByRootRequester), | |||
| DataColumnsByRoot(DataColumnsByRootRequestId), | |||
There was a problem hiding this comment.
Having the requester inside the ID just simplifies downstream code and makes it symmetrical with the other variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
To address PeerDAS sync issues we need to make individual by_range requests within a batch retriable. We should adopt the same pattern for lookup sync where each request (block/blobs/columns) is tracked individually within a "meta" request that group them all and handles retry logic.
The first step is to add
ActiveBlocksByRangeRequest,ActiveBlobsByRangeRequestandActiveDataColumnsByRangeRequest. I'm in the progress of doing that in this branch https://github.com/sigp/lighthouse/compare/unstable...dapplion:lighthouse:sync-active-requests?expand=1 but I noted a lot of sensitive code repetition.This PR is pre-step to add
ActiveRequestto our existingActiveRequest*ByRoot(the ones for by_root). Next PR will add theActiveRequest*ByRangegoodies :)