Light client updates by range RPC #6383
Open
+350
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Sep 11, 2024
beacon_node/network/src/network_beacon_processor/rpc_methods.rs
Outdated
Show resolved
Hide resolved
| self.log, | ||
| "LightClientUpdatesByRange outgoing response processed"; | ||
| "peer" => %peer_id, | ||
| "msg" => "Failed to return all requested light client updates", |
There was a problem hiding this comment.
Could be that the peer requested updates ahead of what's currently available, not our fault.
beacon_node/network/src/network_beacon_processor/rpc_methods.rs
Outdated
Show resolved
Hide resolved
dapplion
approved these changes
Sep 14, 2024
eserilev
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #3651
Proposed Changes
Enable light client updates request over RPC