Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix electra light client types #6361

Open
wants to merge 108 commits into
base: unstable
Choose a base branch
from
Open

Fix electra light client types #6361

wants to merge 108 commits into from

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Sep 5, 2024 •
edited
Loading

Issue Addressed

Resolves #6002

Resolves #4022

Proposed Changes

Update light client types to be compatible with electra

Related spec PR:

ethereum/consensus-specs#3811

Blocked by #5915

@eserilev
persist light client updates
914bb1e
@eserilev
update beacon chain to serve light client updates
c308768
@eserilev
resolve todos
e332b00
@eserilev
cache best update
3a93933
@eserilev
extend cache parts
b9bdd88
@eserilev
is better light client update
9671423
@eserilev
resolve merge conflict
5861417
@eserilev
initial api changes
6e0fa26
@eserilev
add lc update db column
c8af8fb
@eserilev
fmt
45a5d8d
@eserilev
added tests
2545655
@eserilev
add sim
3029f2c
@eserilev
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pe…
fad083a 
…rsist-light-client-updates
@eserilev
fix some weird issues with the simulator
49a7e61
@eserilev
tests
00d4fd0
@eserilev
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pe…
4b8683c 
…rsist-light-client-updates
@eserilev
test changes
6f12133
@eserilev
merge conflict
9464518
@eserilev
testing
22e9201
@eserilev
started work on ef tests and some code clean up
1946100
@eserilev
update tests
2b1e47d
@eserilev
linting
211601c
@eserilev
noop pre altair, were still failing on electra though
891d677
@eserilev
allow for zeroed light client header
d729fea
@eserilev
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pe…
58f178a 
…rsist-light-client-updates
@eserilev
merge unstable
fe2b43d
@eserilev
remove unwraps
1774e63
@eserilev
remove unwraps
af9b20d
@eserilev
fetch bootstrap without always querying for state
d82226b
@eserilev
storing bootstrap parts in db
ce765f3
@eserilev eserilev added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Sep 7, 2024
@eserilev eserilev removed the blocked label Sep 10, 2024
dapplion
dapplion reviewed Sep 10, 2024
View reviewed changes
beacon_node/beacon_chain/src/light_client_server_cache.rs Outdated Show resolved Hide resolved
beacon_node/store/src/hot_cold_store.rs Outdated Show resolved Hide resolved
consensus/types/src/light_client_update.rs Outdated Show resolved Hide resolved
consensus/types/src/light_client_update.rs Outdated Show resolved Hide resolved
consensus/types/src/beacon_state.rs Outdated Show resolved Hide resolved
consensus/types/src/beacon_state.rs Outdated Show resolved Hide resolved
consensus/types/src/beacon_state.rs Outdated Show resolved Hide resolved
consensus/types/src/beacon_state.rs Outdated Show resolved Hide resolved
dapplion
dapplion approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Until we have generalized proof generation this version looks like the most sound to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
electra Required for the Electra/Prague fork light-client ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eserilev @dapplion