Stricter match of BlockError in lookup sync #6321
Open
+299
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
commented
Aug 28, 2024
| for peer in peer_group.of_index(index) { | ||
| cx.report_peer( | ||
| *peer, | ||
| PeerAction::MidToleranceError, |
There was a problem hiding this comment.
I think we should up this to LowToleranceError
dapplion
commented
Aug 28, 2024
| ); | ||
| let recoverable = match other.rpc_scoring() { | ||
| ErrorCategory::Internal { recoverable } => { | ||
| if matches!(other, BlockError::ExecutionPayloadError(_)) { |
There was a problem hiding this comment.
I kept this extra condition from the original match as I imagine that when EL goes offline the node would spam non-actionable errors
dapplion
commented
Aug 28, 2024
dapplion
commented
Aug 28, 2024
dapplion
force-pushed
the
peerdas-peergroup-scoring
branch
from
a2ffbd2
to
5a69a7b
Compare
pawanjay176
added
the
under-review
pawanjay176
reviewed
Sep 6, 2024
beacon_node/network/src/network_beacon_processor/sync_methods.rs
Outdated
Show resolved
Hide resolved
beacon_node/beacon_chain/src/data_availability_checker/error.rs
Outdated
Show resolved
Hide resolved
beacon_node/beacon_chain/src/data_availability_checker/error.rs
Outdated
Show resolved
Hide resolved
beacon_node/beacon_chain/src/data_availability_checker/error.rs
Outdated
Show resolved
Hide resolved
dapplion
changed the base branch from
unstable
to
peerdas-peergroup-scoring-only
dapplion
changed the title
realbigsean
changed the base branch from
peerdas-peergroup-scoring-only
to
unstable
dapplion
force-pushed
the
peerdas-peergroup-scoring
branch
from
5a69a7b
to
33d10e5
Compare
dapplion
changed the title
|
@pawanjay176 I have moved the big match into the network beacon processor. This is analogous to how we handle the result of processing chain segments and gossip objects. I have applied all your comments to the current version. I think the PR makes much more sense now, ready for a re-review |
dapplion
commented
Oct 20, 2024
| "Error processing block component"; | ||
| "block_root" => %block_root, | ||
| "err" => ?err, | ||
| ); |
There was a problem hiding this comment.
Do we want to log internal errors at a higher level than debug? If yes I can move the log statement below and match the type of ErrorCategory
dapplion
added
ready-for-review
This was referenced Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Adds a strict match without fallbacks to handle all processing errors in lookup sync explicitly. With this we can:
Example problem 1
Today, if a block has incorrect state root we will download and process it 5 times. This is wasteful, we should discard the block immediately
Example problem 2
Assume we introduce a new
BlockErrorvariant in a future fork or network change. Lookup sync is very sensitive code, and not handling this error variant properly may result in sync getting stuckProposed Changes
In the network processor convert
BlockErrortoLookupSyncProcessingResult.Then lookup sync logic is quite simple match on
LookupSyncProcessingResult, without fallbacks.