Drop lookup type trait for a simple arg

[dapplion]

Issue Addressed

Part of

• Block lookup sync technical debt #5549

Passing around a simple lookup_type: LookupType to the requester function achieves the same functionality with less machinery. Makes code simpler to extend, related to DAS.

Proposed Changes

• Drop lookup type trait for a simple arg
• Drop leftover unit tests in beacon_node/network/src/sync/block_lookups/single_block_lookup.rs. Their tested scenarios are covered by the event-based tests

[realbigsean]

Nice

[realbigsean]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[jimmygchen]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c38b05d