feat: options method return status 200

sigoden · Jun 12, 2022 · dd8b21f · dd8b21f
1 parent 471bca8
commit dd8b21f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/server.rs b/src/server.rs
@@ -210,7 +210,7 @@ impl InnerService {
                 }
             }
             Method::OPTIONS => {
-                self.handle_method_options(&mut res);
+                self.handle_options(&mut res);
             }
             Method::PUT => {
                 if !allow_upload || (!allow_delete && is_file && size > 0) {
@@ -549,16 +549,14 @@ impl InnerService {
         Ok(())
     }
 
-    fn handle_method_options(&self, res: &mut Response) {
+    fn handle_options(&self, res: &mut Response) {
         res.headers_mut().insert(
             "Allow",
             "GET,HEAD,PUT,OPTIONS,DELETE,PROPFIND,COPY,MOVE"
                 .parse()
                 .unwrap(),
         );
         res.headers_mut().insert("DAV", "1".parse().unwrap());
-
-        status!(res, StatusCode::NO_CONTENT);
     }
 
     async fn handle_propfind_dir(

diff --git a/tests/http.rs b/tests/http.rs
@@ -129,7 +129,7 @@ fn head_file_404(server: TestServer) -> Result<(), Error> {
 #[rstest]
 fn options_dir(server: TestServer) -> Result<(), Error> {
     let resp = fetch!(b"OPTIONS", format!("{}index.html", server.url())).send()?;
-    assert_eq!(resp.status(), 204);
+    assert_eq!(resp.status(), 200);
     assert_eq!(
         resp.headers().get("allow").unwrap(),
         "GET,HEAD,PUT,OPTIONS,DELETE,PROPFIND,COPY,MOVE"