Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load dotenv before handle @env #308

Merged
merged 1 commit into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/build.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::{
command::Command,
param::{FlagOptionParam, Param},
utils::{escape_shell_words, expand_dotenv, META_DOTENV},
utils::{escape_shell_words, expand_dotenv},
ChoiceValue, DefaultValue,
};
use anyhow::Result;
Expand Down Expand Up @@ -193,7 +193,7 @@ pub fn build(source: &str, root_name: &str) -> Result<String> {

fn build_root(cmd: &Command) -> String {
let command = build_command(cmd);
let dotenv = if let Some(value) = cmd.get_metadata(META_DOTENV) {
let dotenv = if let Some(value) = cmd.dotenv() {
format!("\n {}", expand_dotenv(value))
} else {
String::new()
Expand Down Expand Up @@ -224,8 +224,8 @@ _argc_run() {{
argc__args=("$(basename "$0" .sh)" "$@")
argc__positionals=()
_argc_index=1
_argc_len="${{#argc__args[@]}}"
_argc_parse{dotenv}{before_hook}
_argc_len="${{#argc__args[@]}}"{dotenv}
_argc_parse{before_hook}
if [ -n "$argc__fn" ]; then
$argc__fn "${{argc__positionals[@]}}"{after_hook}
fi
Expand Down
13 changes: 7 additions & 6 deletions src/command/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,7 @@ impl Command {
if self.get_metadata(META_COMBINE_SHORTS).is_some() {
extra.insert("combine_shorts".into(), true.into());
}
if let Some(dotenv) = self.get_metadata(META_DOTENV) {
let dotenv = if dotenv.is_empty() {
".env".to_string()
} else {
dotenv.to_string()
};
if let Some(dotenv) = self.dotenv() {
extra.insert("dotenv".into(), dotenv.into());
}
let (before_hook, after_hook) = self.exist_hooks();
Expand Down Expand Up @@ -611,6 +606,12 @@ impl Command {
&& self.positional_params[0].terminated()
}

pub(crate) fn dotenv(&self) -> Option<&str> {
let dotenv = self.get_metadata(META_DOTENV)?;
let dotenv = if dotenv.is_empty() { ".env" } else { dotenv };
Some(dotenv)
}

fn update_recursively(&mut self, paths: Vec<String>) {
self.paths = paths.clone();

Expand Down
13 changes: 9 additions & 4 deletions src/matcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::{
command::{Command, SymbolParam},
compgen::CompColor,
param::{ChoiceValue, FlagOptionParam, Param, ParamData, PositionalParam},
utils::{argc_var_name, run_param_fns, META_COMBINE_SHORTS, META_DOTENV},
utils::{argc_var_name, load_dotenv, run_param_fns, META_COMBINE_SHORTS},
Shell,
};

Expand Down Expand Up @@ -292,10 +292,15 @@ impl<'a, 'b> Matcher<'a, 'b> {
}
}

let mut envs = HashMap::new();
let last_cmd = *cmds.last().unwrap();

let mut envs = HashMap::new();
let dotenv_vars = root_cmd.dotenv().and_then(load_dotenv).unwrap_or_default();
for param in &last_cmd.env_params {
if let Ok(value) = std::env::var(param.id()) {
if let Some(value) = std::env::var(param.id())
.ok()
.or_else(|| dotenv_vars.get(param.id()).cloned())
{
envs.insert(param.id(), value);
}
add_param_choice_fn(&mut choice_fns, param)
Expand Down Expand Up @@ -476,7 +481,7 @@ impl<'a, 'b> Matcher<'a, 'b> {
let level = cmds_len - 1;
let last_cmd = self.cmds[level];

if let Some(value) = root_cmd.get_metadata(META_DOTENV) {
if let Some(value) = root_cmd.dotenv() {
output.push(ArgcValue::Dotenv(value.to_string()))
}

Expand Down
20 changes: 18 additions & 2 deletions src/utils.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use convert_case::{Boundary, Converter, Pattern};
use std::{
collections::HashMap,
env,
env, fs,
path::{Path, PathBuf},
process, thread,
};
Expand Down Expand Up @@ -186,7 +186,7 @@ pub fn path_env_with_exe() -> String {
}

pub fn expand_dotenv(value: &str) -> String {
let value = if value.is_empty() { ".env" } else { value };
let value = escape_shell_words(value);
format!("[ -f {value} ] && set -o allexport && . {value} && set +o allexport")
}

Expand All @@ -198,6 +198,22 @@ pub fn argc_var_name(id: &str) -> String {
format!("{VARIABLE_PREFIX}{}", sanitize_var_name(id))
}

pub fn load_dotenv(path: &str) -> Option<HashMap<String, String>> {
let contents = fs::read_to_string(path).ok()?;
let mut output = HashMap::new();
for line in contents.lines() {
if line.starts_with('#') || line.trim().is_empty() {
continue;
}
if let Some((key, value)) = line.split_once('=') {
let key = key.trim().to_string();
let value = value.trim().to_string();
output.insert(key, value);
}
}
Some(output)
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down