Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed precision issueswith small amounts in getRecipientAmount #55

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: fixed precision issueswith small amounts in getRecipientAmount #55

merged 3 commits into from
Mar 31, 2023

Conversation

ohager
Copy link
Member

@ohager ohager commented Mar 31, 2023

using Amount for getRecipientAmounts and removing deprecated convertNQTString from methods, as they cause precision issues with very small amounts

@ohager ohager marked this pull request as ready for review March 31, 2023 16:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@ohager ohager merged commit 87e039c into main Mar 31, 2023
@ohager ohager deleted the fix/multiout-precision branch March 31, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ohager