fix: added more unit tests and fixed tld on setAlias (#48)

signum-network · Mar 17, 2023 · 1cf4370 · 1cf4370
1 parent 58691a0
commit 1cf4370
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 2 deletions.
diff --git a/packages/core/src/api/__tests__/aliasApi.spec.ts b/packages/core/src/api/__tests__/aliasApi.spec.ts
@@ -5,7 +5,7 @@ import {
     getAliasesOnSale,
     buyAlias,
     sellAlias,
-    getAliasByName, buyTopLevelDomain, getTopLevelDomains
+    getAliasByName, buyTopLevelDomain, getTopLevelDomains, setAlias
 } from '../factories';
 import {mockSignAndBroadcastTransaction, createChainService} from '../../__tests__/helpers';
 import {searchAliasesByName} from '../factories/alias/searchAliasesByName';
@@ -162,6 +162,45 @@ describe('Alias Api', () => {
         });
     });
 
+
+    describe('setAlias', () => {
+        it('should setAlias using default TLD', async () => {
+            httpMock = HttpMockBuilder.create().onPostReply(200, {
+                broadcasted: true,
+                'transaction': 'transactionId'
+                },
+                'relPath?requestType=setAlias&aliasName=aliasName&aliasURI=aliasURI&deadline=1440&feeNQT=100000&publicKey=senderPublicKey'
+            ).build();
+            const service = createChainService(httpMock, 'relPath');
+            const asset = await setAlias(service)({
+                feePlanck: '100000',
+                aliasName: 'aliasName',
+                aliasURI: "aliasURI",
+                senderPublicKey: 'senderPublicKey',
+                senderPrivateKey: 'senderPrivateKey',
+            });
+            expect(asset).toEqual({'transaction': 'transactionId'});
+        });
+        it('should setAlias using custom TLD', async () => {
+            httpMock = HttpMockBuilder.create().onPostReply(200, {
+                broadcasted: true,
+                'transaction': 'transactionId'
+                },
+                'relPath?requestType=setAlias&aliasName=aliasName&aliasURI=aliasURI&deadline=1440&feeNQT=100000&publicKey=senderPublicKey&tld=tld'
+            ).build();
+            const service = createChainService(httpMock, 'relPath');
+            const asset = await setAlias(service)({
+                feePlanck: '100000',
+                aliasName: 'aliasName',
+                tld: "tld",
+                aliasURI: "aliasURI",
+                senderPublicKey: 'senderPublicKey',
+                senderPrivateKey: 'senderPrivateKey',
+            });
+            expect(asset).toEqual({'transaction': 'transactionId'});
+        });
+    });
+
     describe('searchAliasesByName', () => {
         it('should search as expected', async () => {
             httpMock = HttpMockBuilder.create().onGetReply(200, {'aliases': []},

diff --git a/packages/core/src/api/factories/account/setAlias.ts b/packages/core/src/api/factories/account/setAlias.ts
@@ -24,7 +24,8 @@ export const setAlias = (service: ChainService) =>
                 deadline: a.deadline || DefaultDeadline,
                 feeNQT: a.feePlanck,
                 publicKey: a.senderPublicKey,
-                referencedTransactionFullHash: a.referencedTransactionFullHash
+                referencedTransactionFullHash: a.referencedTransactionFullHash,
+                tld: args.tld || undefined
             };
             return service.send<UnsignedTransaction>('setAlias', parameters);
         });