Merge pull request #28 from signifyd/stage

Version 3.4.4
signifyd · Sep 25, 2019 · 2a0d385 · 2a0d385
2 parents 2d255c8 + b1d917e
commit 2a0d385
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/Controller/Webhooks/Index.php b/Controller/Webhooks/Index.php
@@ -126,7 +126,7 @@ public function processRequest($request, $hash, $topic)
             $caseData = array(
                 "case" => $case,
                 "order" => $order,
-                "request" => $requestJson
+                "response" => $requestJson
             );
 
             if ($case->isEmpty()) {

diff --git a/Helper/FulfillmentHelper.php b/Helper/FulfillmentHelper.php
@@ -243,6 +243,11 @@ public function getTrackingNumbers(\Magento\Sales\Model\Order\Shipment $shipment
         $trackingNumbers = array();
 
         $trackingCollection = $shipment->getTracksCollection();
+        /**
+         * Sometimes Magento loads tracking collection before the $shipment object gets loaded, leaving collection
+         * without shipment filter. Forcing shipment filter to avoid issues.
+         */
+        $trackingCollection->setShipmentFilter($shipment->getId());
 
         /** @var \Magento\Sales\Model\Order\Shipment\Track $tracking */
         foreach ($trackingCollection->getItems() as $tracking) {

diff --git a/composer.json b/composer.json
@@ -7,7 +7,7 @@
     "php": ">=5.5.22"
   },
   "type": "magento2-module",
-  "version": "3.4.3",
+  "version": "3.4.4",
   "autoload": {
     "files": [
       "registration.php"

diff --git a/etc/module.xml b/etc/module.xml
@@ -5,7 +5,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Signifyd_Connect" setup_version="3.4.3">
+    <module name="Signifyd_Connect" setup_version="3.4.4">
         <sequence>
             <module name="Magento_Sales" />
             <module name="Magento_Payment" />