Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update actions to use Node.js 20 #953

Merged
merged 1 commit into from
Jan 31, 2024
Merged

build: Update actions to use Node.js 20 #953

merged 1 commit into from
Jan 31, 2024

Conversation

ryanwi
Copy link
Contributor

@ryanwi ryanwi commented Jan 31, 2024

Description

Fixes deprecation warning

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 1d19410

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -12,7 +12,7 @@ runs:
steps:
- name: Cache dist folders
id: cache
uses: actions/cache@v3
uses: actions/cache@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be updating the node version in the inputs?

Currently. it is 18.x, we can replace it with 20.x

Similar to what I did in this PR #911

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that can be separate as it has more if a direct impact in the sdk code/ci. The gha upgrades are isolated from that standpoint.

@ryanwi ryanwi merged commit 31bca0d into main Jan 31, 2024
6 of 10 checks passed
@ryanwi ryanwi deleted the ryanwi/update-gha branch January 31, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants