Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET to version 8 #5953

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Mar 6, 2025

Latest release of Splunk Distribution of OpenTelemetry .NET doesn't support net6.0 and also hit a known issue that requires a workaround.

@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net6.0 is not supported anymore by the Splunk distro.

@@ -27,7 +27,7 @@ if (!(Test-Path (Join-Path $docker_setup_path splunk-otel-collector-*.msi) -Path
# 2. ASP.NET Core IIS hosting bundle
if (!(Test-Path (Join-Path $docker_setup_path dotnet-hosting-win.exe) -PathType Leaf)) {
$dotnet_hosing_exe = Join-Path $docker_setup_path dotnet-hosting-win.exe
Invoke-WebRequest -Uri https://aka.ms/dotnet/6.0/dotnet-hosting-win.exe -OutFile $dotnet_hosing_exe -UseBasicParsing
Invoke-WebRequest -Uri https://aka.ms/dotnet/8.0/dotnet-hosting-win.exe -OutFile $dotnet_hosing_exe -UseBasicParsing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net6.0 is not supported anymore by the Splunk distro.

pjanotti added 2 commits March 6, 2025 15:56
…ithub.com:pjanotti/splunk-otel-collector into update-dotnet-version-for-zeroconfig-windows-test
@pjanotti pjanotti marked this pull request as ready for review March 7, 2025 00:11
@pjanotti pjanotti requested review from a team as code owners March 7, 2025 00:11
@pjanotti pjanotti merged commit a4dd36d into signalfx:main Mar 7, 2025
114 of 116 checks passed
@pjanotti pjanotti deleted the update-dotnet-version-for-zeroconfig-windows-test branch March 7, 2025 01:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants