Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tiny]Fix: display msiexec exit code on install.ps1 #5948

Merged
merged 1 commit into from
Mar 5, 2025
Merged

[tiny]Fix: display msiexec exit code on install.ps1 #5948

merged 1 commit into from
Mar 5, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Mar 4, 2025

Current install.ps1 is not showing the exit code of the msiexec.exe run - this tiny PR fixes that.

@pjanotti pjanotti requested review from a team as code owners March 4, 2025 18:01
@pjanotti pjanotti merged commit e8b714c into signalfx:main Mar 5, 2025
21 of 101 checks passed
@pjanotti pjanotti deleted the tiny-fix-display-msiexec-exit-code branch March 5, 2025 00:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

@jinja2 jinja2 jinja2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjanotti @atoulme @jinja2