Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MSI ProductCode on every release #5929

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Feb 21, 2025

Re-instate upgrade via MSI: this was changed deliberately because I was not aware of anybody using this upgrade mechanism - the script and others always require an explicit uninstall before hand. However, it came to my knowledge that some users are relying on upgrading via the MSI without doing an explicit uninstall first. In light of that I'm re-instating the unique product id per release that allows the MSI to be used this way.

@pjanotti pjanotti marked this pull request as ready for review March 4, 2025 05:40
@pjanotti pjanotti requested review from a team as code owners March 4, 2025 05:40
@pjanotti pjanotti merged commit e586a6f into signalfx:main Mar 4, 2025
129 of 131 checks passed
@pjanotti pjanotti deleted the allow-msi-upgrade branch March 4, 2025 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants