[chore] Update default metric_relabel_configs for internal metrics #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
exlude-redundant-metrics
branch
from
f464643 to
6d1a614
Compare
grpc and http metrics are now only sent in detailed level. So, no need to exclude them. However, there is another redundant metric emitted by default in 0.119.0 after the transition to OTel SDK, `promhttp_metric_handler_errors`. This change updates the default configs and the appropriate converter to exclude this metric.
dmitryax
force-pushed
the
exlude-redundant-metrics
branch
from
6d1a614 to
70fe718
Compare
crobert-1
approved these changes
Feb 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC and HTTP metrics are now only sent at the detailed level. So, no need to exclude them anymore. However, there is another redundant metric emitted by default in 0.119.0 after the transition to OTel SDK,
promhttp_metric_handler_errors. This change updates the default configs and the appropriate converter to exclude this metric.