Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm generated instead of cert-manager generated certs for the operator #1648

Merged
merged 25 commits into from
Mar 3, 2025

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Feb 5, 2025

Description:

Testing:

  • The added migration steps were tested manually.
  • The functional test golden file expected_cluster_receiver.yaml that is used for validation had to be regenerated because by removing cert-manager we removed 3 cert-manager pods that previously generated metrics that were collected.
  • Our functional tests also include 2 "upgrade" tests which are expected to fail (due to reasons outlined in UPGRADING.md), thus I had to add the "Ignore Tests" label to this PR. No other tests will be failing except for these upgrading tests, I've linked an instance of these failures for one of the latest commits below.

…the functional aks tests to use certmanager for testing coverage
@jinja2
Copy link
Collaborator

jinja2 commented Feb 14, 2025

I think we'll need an entry for how existing certmanager subchart users can keep their current setup in the upgrading guide which we can link to in a changelog entry.

And I think it would be good to document if user can safely disable existing certmanager and use the autogenerate feature when they helm upgrade to a version of chart with this change.

@jvoravong jvoravong marked this pull request as ready for review February 26, 2025 17:57
@jvoravong jvoravong requested review from a team as code owners February 26, 2025 17:57
@jvoravong jvoravong changed the title [Draft] Use Helm generated instead of cert-manager generated certs for the operator Use Helm generated instead of cert-manager generated certs for the operator Feb 26, 2025
@jvoravong jvoravong requested a review from jinja2 February 27, 2025 18:26
@jvoravong jvoravong added the Ignore Tests Ignores functional-tests in order to adopt known breaking changes label Feb 27, 2025
@jvoravong jvoravong removed the Ignore Tests Ignores functional-tests in order to adopt known breaking changes label Mar 3, 2025
@jvoravong
Copy link
Contributor Author

Having to use a different PR label to get the upgrade tests to pass, a new PR label can be added after #1682.

Co-authored-by: Jina Jain <[email protected]>
@jvoravong jvoravong merged commit 5cf9dbb into main Mar 3, 2025
77 checks passed
@jvoravong jvoravong deleted the otl-2900-migration branch March 3, 2025 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants